Fix db documentation#512
Merged
samtstern merged 1 commit intofirebase:version-1.1.0-devfrom Jan 11, 2017
SUPERCILEX:fix-docs
Merged
Fix db documentation#512samtstern merged 1 commit intofirebase:version-1.1.0-devfrom SUPERCILEX:fix-docs
samtstern merged 1 commit intofirebase:version-1.1.0-devfrom
SUPERCILEX:fix-docs
Conversation
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
SUPERCILEX
commented
Jan 11, 2017
| * to complete a batch update to a UI element. | ||
| */ | ||
| protected void onDataChanged() { | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Methods should not be positioned before constructors.
Contributor
There was a problem hiding this comment.
I thought I added it near the end, didn't I?
Collaborator
Author
There was a problem hiding this comment.
Nope, you added it before a constructor at line 98. I put between onCancelled.
This was referenced Jan 11, 2017
Contributor
|
LGTM, good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@samtstern It looks like @puf forgot the second
*makingonDataChangedappear to have no documentation. Oops! 😄